AIT-376: scrub internal planning references from the public source - #56
Conversation
…public source Code comments carried internal spec/plan paths, phase-numbering breadcrumbs, and one absolute local path in the analytics manifest. Comments keep their descriptive content; only the internal references are gone. No behavior change.
|
@codex review |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (29)
🚧 Files skipped from review as they are similar to previous changes (23)
📝 WalkthroughWalkthroughThe pull request removes historical phase, plan, research, and context references from source comments, test descriptions, manifest metadata, and selected error text. Runtime behavior, tests, assertions, APIs, and exported declarations remain unchanged. ChangesDocumentation reference cleanup
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Note This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. Track spend and usage in your billing settings. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8452052fa9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/commands/_helpers.ts`:
- Around line 55-60: Remove the unclear “an earlier revision” wording at all
listed sites: in src/commands/_helpers.ts lines 55-60, use a direct comment
prefix and “The CLI requires”; in lines 189-196, use “the exit-code mapping
table”; in src/commands/channels.ts lines 116-119 and src/api/client.ts lines
266-268, use “the existing exit-code contract”; in
src/commands/sandbox-listen/index.ts lines 313-316, use “The value must be a”;
remove the prefix in src/__tests__/telemetry-consent.test.ts line 220; and
replace the malformed alias description in src/api/client.ts lines 193-194 with
a direct type-alias description.
In `@src/commands/workspace.ts`:
- Line 93: Update the raw-UUID error message in the workspace command to replace
“an earlier revision CLI requires” with the clear, grammatical phrase “The CLI
requires,” while preserving the publicId and workspace-name guidance and rerun
instruction.
In `@src/observability/sentry.ts`:
- Line 304: Remove the internal “CONTEXT.md §125-02” reference from the comment
near the awaited vendor flush behavior, leaving only the descriptive explanation
that both vendors are awaited.
In `@src/output/error.ts`:
- Around line 1-9: Replace the incomplete revision placeholders with precise
neutral wording: in src/output/error.ts lines 1-9, describe the
CliError/AppError compatibility using grammatical “legacy” and “current” terms;
in src/errors/index.ts lines 12-14, refer to “legacy code paths” and “current
code paths”; in src/analytics/events.ts line 4, rewrite the byte-for-byte
history statement without repeating “an earlier revision”; and in
src/observability/posthog.ts lines 344-348, replace “an earlier revision
follow-up” with a direct description such as “Follow-up: attach...”.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 27b09da8-7378-4524-a62a-93ac37c91045
📒 Files selected for processing (34)
src/__tests__/cli-events.test.tssrc/__tests__/errors-manifest.test.tssrc/__tests__/flush-exit.test.tssrc/__tests__/manifest-drift.test.tssrc/__tests__/posthog-alias.test.tssrc/__tests__/posthog-init.test.tssrc/__tests__/sentry-init.test.tssrc/__tests__/telemetry-consent.test.tssrc/__tests__/workspace-list.spec.tssrc/__tests__/workspace.test.tssrc/analytics/events.manifest.jsonsrc/analytics/events.tssrc/api/client.tssrc/api/version-headers.tssrc/auth/__tests__/login.test.tssrc/auth/login.tssrc/commands/__tests__/wizard.test.tssrc/commands/_helpers.tssrc/commands/channels-listen/index.tssrc/commands/channels.tssrc/commands/config.tssrc/commands/sandbox-listen/index.tssrc/commands/workspace.tssrc/config/__tests__/env-profiles.test.tssrc/config/index.tssrc/errors/base.tssrc/errors/index.tssrc/index.tssrc/lib/publicId.tssrc/observability/jwt-light.tssrc/observability/posthog.tssrc/observability/sentry.tssrc/observability/telemetry.tssrc/output/error.ts
💤 Files with no reviewable changes (1)
- src/commands/channels-listen/index.ts
…l doc references gone The first pass left awkward 'an earlier revision' phrasings (including in the raw-UUID --workspace error) and missed CONTEXT.md / RESEARCH references. Error strings read plainly again; comments keep their meaning with no internal document names. 1092 tests green.
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
AIT-376: scrub internal planning references from the public source
Refs AIT-376 (release hygiene before the v0.14.12 tag)
Pre-publish sweep of the public repo found internal breadcrumbs in code comments:
docs/superpowers/specs|plans/...paths inversion-headers.tsandchannels-listen/index.tssrc/analytics/events.manifest.json's descriptionComments keep their descriptive meaning; only the internal references are removed. No code change — 1092 tests green, tsc clean.
Summary by CodeRabbit
Documentation
Tests